The scope switch is gone. It existed because "select a folder" was ambiguous
in a list that could not show folders, and turning that ambiguity into a
control just moved the problem onto the user.
The list now shows what a folder contains: its sub-folders as entries first,
then the documents directly inside it. So the mode follows what the user is
already doing instead of a switch - browsing shows one level, and any active
filter searches the whole subtree flat, with a breadcrumb note saying so. A
document uploaded on its own needs no special row either: it sits at the top
level next to the folders, exactly where it is.
Folders can also be adjusted now, which they could not before - a mis-filed
upload previously had to be deleted and re-uploaded. Documents move via the
row menu or the batch bar into an existing or newly typed folder, and a
folder can be renamed in place, carrying its subtree. Both are plain
folder_path updates: nothing is re-parsed, re-chunked or re-embedded.
A folder-only tree cannot show a node for a document that is not in any
folder, so single-file uploads were unreachable from the sidebar: a base
with 5 documents and one 3-document folder just left two of them
unaccounted for.
Rather than add a second pseudo-folder row for them (the ambiguity the
previous commit removed), the one existing mechanism is made visible: the
scope switch is now a labeled segmented control instead of an icon behind a
tooltip, and the root row is named after whatever the current scope makes it
list - the whole base, or exactly the unfiled documents. The breadcrumb's
leading crumb follows the same rule.
The sidebar listed "all documents" and "root" as two rows sitting next to
the top-level folders, but those folders are inside the root, so the three
rows contradicted each other and reaching the top level for an upload meant
selecting a row that did not look like a parent.
There is now a single root row with every folder nested beneath it, and what
a row lists is decided by one uniform rule at every level: the direct
documents, or the whole subtree when the scope toggle is on. "Documents not
in any folder" is the root with the toggle off, which is also why the toggle
now defaults to on.
The upload destination is no longer implied by the sidebar selection either:
the confirmation dialog shows which folder the batch lands in, lets it be
switched back to the top level, and lists each file's own sub-directory.
The upload-path builder, breadcrumb/ancestor derivation, folder lookup and
tree flattening were inline in the view and the sidebar component. Moving
them into folderTree.ts follows the convention of kbListMerge.ts and
wikiStatusRefresh.ts, removes the duplicated webkitRelativePath handling,
and makes the folder navigation logic directly testable.
The documents tab gains a left folder column built from the folder_path
now stored on each knowledge entry. Selecting a folder filters the
existing document list (so search, tags, type, status and date filters
all keep working), a breadcrumb above the list shows where you are, and
uploads made while browsing a folder land in that folder. A per-row
folder chip appears only when the list can span folders.
Folder uploads used to encode their relative directory inside file_name,
which made the document list render the whole path as the title and left
no way to browse or query a single folder. The directory now lives in a
dedicated folder_path column (with a backfill for existing rows), the
document list accepts folder_path / folder_recursive filters, and a new
GET /knowledge-bases/:id/knowledge/folders endpoint returns the folder
tree with per-folder document counts.
If the embedding provider returns an empty slice of vectors (e.g. length 0)
due to api mismatch or empty input, BatchEmbed will return length 0.
Accessing embedding[i] directly in BatchEmbedWithPool results in an out of bounds panic.
Because the panic occurs inside a mu.Lock() block, the mutex is never unlocked,
leading to a permanent deadlock of the document processing queue.
This fix checks the returned embeddings slice length and returns an error
instead of panicking, releasing the mutex properly.
role="status" lived on the wait row itself, so the live region was inserted
together with its own text and screen readers had nothing to announce. Move the
announcement to an sr-only region that stays mounted for the whole turn, which
also covers the pre-pipeline wait row that had no announcement at all.
Co-authored-by: lyingbug <lyingbug@users.noreply.github.com>
The wait row only appeared once a completed knowledge_search step existed, so
attachment-only turns (attachment_parsing / image_analysis with no KB hit) still
showed nothing between the last step and the first answer token. Model waiting is
now a three-state kind: 'model' after retrieval finished, the neutral 'preparing'
row otherwise.
A dropped SSE connection never sets is_completed (the stream layer only raises a
toast), so the row used to promise an answer forever. It now stops claiming
progress after RAG_WAIT_STALL_DELAY_MS and drops the shimmer.
Also share RAG_RETRIEVAL_TOOL_NAMES instead of repeating the knowledge_search /
search_knowledge alias check, name the reveal delay, and move the reveal/stall
timers into a controller with an injectable scheduler so the timing is covered by
tests instead of by source-matching alone.
Co-authored-by: lyingbug <lyingbug@users.noreply.github.com>
Follow-up to the error_message clearing added for SetFinalizing,
FinalizeSubtask and ProcessDocument. Two routes still persisted a
previous attempt's failure message:
- ProcessManualUpdate flips a row back to 'processing' without clearing
error_message. A manual knowledge item that failed earlier (for
example when the knowledge base lookup failed, or after an Asynq
retry) re-enters processing still carrying that message, so the UI
shows a failure on a document it also shows as running.
- finalizeIndexedKnowledgeState is the only route to 'completed' that
bypasses FinalizeSubtask. When a document has no text chunks and no
pending multimodal work it is completed in place, so the promotion
that would otherwise clear the column never runs and a successfully
indexed row keeps reporting the earlier failure.
The 'processing' transition is extracted into markKnowledgeProcessing so
ProcessDocument and ProcessManualUpdate share one definition of what
starting a new attempt means, and a future worker cannot reintroduce the
same omission. The helper also replaces the "processing" string literal
with types.ParseStatusProcessing.
Tests: markKnowledgeProcessing gets direct coverage, and the
finalizeIndexedKnowledgeState table now seeds a stale error_message and
asserts it survives the processing branches (FinalizeSubtask clears it
later) and is cleared on the completed branch.
A knowledge item that failed once keeps error_message set; when it is
reprocessed or driven through the finalizing pipeline, the stale message
was never cleared, so the UI kept showing an outdated failure on items
that were processing or had completed successfully.
- SetFinalizing and FinalizeSubtask now clear error_message in the same
atomic UPDATE that transitions parse_status
- ProcessDocument clears knowledge.ErrorMessage when flipping the row
to processing for a new attempt
Add a SQLite-backed regression test covering both transitions.
GET /shared-knowledge-bases returns rows with nested knowledge_base
(sharedKBRow), unlike GET /knowledge-bases which returns flat KB objects.
resolve_kb_id and agent_chat preflight were reading top-level id/name,
so shared KB names never matched. Add _normalize_kb_entries and tests.
resolve_kb_id now searches both own and shared knowledge bases when
resolving a name to UUID. Error messages and docstrings in hybrid_search,
chat, and agent_chat now reference list_shared_knowledge_bases as well.
Co-Authored-By: Claude <noreply@anthropic.com>
Add a new MCP tool to list knowledge bases shared from other workspaces
via the GET /shared-knowledge-bases endpoint, which was previously not
exposed through the MCP server.
- Add WeKnoraClient.list_shared_knowledge_bases() method
- Register list_shared_knowledge_bases() as an @mcp.tool()
Co-Authored-By: Claude <noreply@anthropic.com>
The xlsx URL-import fix left the accepted extension set reachable through two
indirections and widened ApplyKnowledgeProcessOverrides to gate file types for
callers that are not file imports (web URL fetch, connector sync, reparse).
Collapse the set into one map that both isValidFileType and the extension check
read, move the shared validation next to the other file-type predicates, and
return ApplyKnowledgeProcessOverrides to its override-only scope so
resolveFileImportProcessConfig is the only import gate.
Also drop the unreachable branch in createKnowledgeFromFileURL: getFileType
never yields an empty string, so the resolvedFileType fallback and its else arm
could not run. Normalize the resolved type before it reaches the record and the
task payload, and add an invariant test asserting direct upload and URL import
accept the same extensions so #2447 cannot drift back.
Extract shared file-import checks (type, VLM/ASR, video) into
resolveKnowledgeFileImportConfig and reuse them for file URL import.
Also enqueue DataTableSummaryTask for spreadsheet URL imports and reparse.
Embed visitors have no Bearer token, so resource:// images must be fetched
via /api/v1/embed/:channelId/files. Centralize proxy selection in a
protected-file access context and register the embed plane at EmbedPage so
deep renderers like AgentStreamDisplay no longer fall back to /files (401).
Re-add flat-key translations for audit log and knowledge-base activity events
that were dropped or nested incorrectly during i18n pruning. Add a shared
action registry, English defaults, and prune safeguards so regenerate-i18n-locales
reads the working tree and cannot strip these runtime keys again.
Align agent and knowledge base editors so edit saves close the modal,
first-time create stays open with contextual footer hints, and follow-up
actions point users to sharing/integration or data-source configuration.
Two issues caused retrieval metrics (precision, recall, NDCG, MRR, MAP)
to always be 0:
1. recordFinish compared SearchResult.ChunkIndex (the chunk's ordinal
position in the knowledge base) against QAPair.PIDs (the dataset's
original passage IDs). These are different ID spaces that never match.
Fix: use content-based matching to map each retrieved chunk back to
its source passage, with deduplication for multi-chunk passages.
2. getPassageList had an off-by-one error: make([]string, maxPID) with
loop i < maxPID dropped the passage with the highest PID.
Fix: use maxPID+1 and i <= maxPID.
Also adds fallback from rerankResult to searchResult when no rerank
model is configured, matching the pattern in the working copy.
EvalDataset used CreateKnowledgeFromPassage (async), which returns
immediately while chunking/embedding/vector-indexing runs in the
background. The subsequent RAG queries then hit an empty vector store,
so retrieval metrics (precision, recall, NDCG, MRR, MAP) were always 0.
Switch to CreateKnowledgeFromPassageSync, which waits for indexing to
complete before returning — the same pattern already used in
web_search.go for the identical create-then-query flow.
Match Milvus/Tencent VectorDB and CLI semantics where threshold 0
means no score floor, and add a regression test for anti-correlated
vectors that would otherwise be dropped.
Rename the distribution to tencent-weknora-mcp, point metadata at
Tencent/WeKnora, bump to 1.1.1 for the transport/session fixes, and
tighten publish to main/tags only via Trusted Publishing.
Keep stateless HTTP and /sse/messages/ paths aligned with pre-2.x behavior,
use thread-local requests.Session for concurrent tool handlers, and add
transport regression tests.
MCP Python SDK 2.0 removed the low-level Server decorator API
(@app.list_tools() / @app.call_tool() / app.get_capabilities()), so the
server crashed at startup with:
AttributeError: 'Server' object has no attribute 'list_tools'
The released PyPI package weknora-mcp==1.0.1 declared 'mcp>=1.0.0' with
no upper bound, so uvx resolved to the latest 2.0.0 and the plugin's
weknora MCP server could no longer connect.
Fix: rewrite the server on top of the mcp 2.x high-level MCPServer API
(formerly FastMCP), and cap the dependency at 'mcp>=2,<3'.
- weknora_mcp_server.py: replace @app.list_tools()/@app.call_tool() with
28 @mcp.tool() function-signature tools (input schema auto-generated
from type hints, descriptions from docstrings, plain return values
serialized by the framework). Transports use run_stdio_async() /
sse_app() / streamable_http_app(). WeKnoraClient business logic is
unchanged.
- deps: mcp>=2,<3 in pyproject.toml / requirements.txt / setup.py;
commit uv.lock pinning mcp 2.0.0.
- version bump to 1.1.0 (pyproject, setup, __init__, main --version,
server_version).
- check_imports.py: validate MCPServer / ToolError / mcp_types imports.
- ci(.github/workflows/mcp-server.yml): publish on merge to main +
manual dispatch, not only on tags; add PyPI version-dedup check so
re-runs on an unchanged version stay green (absorbed from PR #2399).
Verified: stdio initialize + tools/list returns all 28 tools; no
list_tools AttributeError; tool dispatch + error wrapping confirmed.
Co-authored-by: wizardchen <wizardchen@tencent.com>