fix(embedding): prevent ants worker panic and mutex deadlock on empty/mismatched results

If the embedding provider returns an empty slice of vectors (e.g. length 0)
due to api mismatch or empty input, BatchEmbed will return length 0.
Accessing embedding[i] directly in BatchEmbedWithPool results in an out of bounds panic.
Because the panic occurs inside a mu.Lock() block, the mutex is never unlocked,
leading to a permanent deadlock of the document processing queue.

This fix checks the returned embeddings slice length and returns an error
instead of panicking, releasing the mutex properly.
main
ljl 2026-08-04 15:37:44 +08:00 committed by lyingbug
parent fcc4cd6a9f
commit 2b31d3681b
1 changed files with 9 additions and 0 deletions

View File

@ -2,6 +2,7 @@ package embedding
import (
"context"
"fmt"
"os"
"strconv"
"sync"
@ -60,6 +61,14 @@ func (e *batchEmbedder) BatchEmbedWithPool(ctx context.Context, model Embedder,
mu.Unlock()
return
}
if len(embedding) != len(texts) {
mu.Lock()
if firstErr == nil {
firstErr = fmt.Errorf("embedding model returned %d embeddings for %d inputs", len(embedding), len(texts))
}
mu.Unlock()
return
}
mu.Lock()
for i, text := range texts {
if text == nil {