From bc350c2eb22b00ac047acf02957032b142927f70 Mon Sep 17 00:00:00 2001
From: shaohuzhang1 <80892890+shaohuzhang1@users.noreply.github.com>
Date: Thu, 10 Jul 2025 20:50:22 +0800
Subject: [PATCH] fix: Tool permission settings (#3553)

---
 apps/tools/serializers/tool.py | 1 -
 apps/tools/views/tool.py       | 3 +++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/apps/tools/serializers/tool.py b/apps/tools/serializers/tool.py
index 4275ef0c5..d10aec7cc 100644
--- a/apps/tools/serializers/tool.py
+++ b/apps/tools/serializers/tool.py
@@ -298,7 +298,6 @@ class ToolSerializer(serializers.Serializer):
                 if get_authorized_tool:
                     if not get_authorized_tool(QuerySet(Tool).filter(id=self.data.get('id')), workspace_id).exists():
                         raise AppApiException(500, _('Tool id does not exist'))
-                raise AppApiException(500, _('Tool id does not exist'))
 
         def is_valid(self, *, raise_exception=False):
             super().is_valid(raise_exception=True)
diff --git a/apps/tools/views/tool.py b/apps/tools/views/tool.py
index f25cea7bd..d70755057 100644
--- a/apps/tools/views/tool.py
+++ b/apps/tools/views/tool.py
@@ -144,6 +144,9 @@ class ToolView(APIView):
             PermissionConstants.TOOL_READ.get_workspace_tool_permission(),
             PermissionConstants.TOOL_READ.get_workspace_permission_workspace_manage_role(),
             RoleConstants.WORKSPACE_MANAGE.get_workspace_role(),
+            PermissionConstants.APPLICATION_READ.get_workspace_permission(),
+            PermissionConstants.APPLICATION_READ.get_workspace_permission_workspace_manage_role(),
+            RoleConstants.USER.get_workspace_role(),
             ViewPermission([RoleConstants.USER.get_workspace_role()],
                            [PermissionConstants.TOOL.get_workspace_tool_permission()],
                            CompareConstants.AND),