WeKnora/internal/im
Ankit Jha 110134f187
test(im): close the lifecycle test database and keep its name unique (#3433)
* test(im): give each lifecycle test its own sqlite database

newLifecycleTestDB derived its in-memory SQLite DSN from
time.Now().UnixNano() alone. Two tests whose helper calls land in the
same wall-clock tick get the same DSN, and since the database is
cache=shared, the second test's CREATE TABLE collides with the
first's ("table im_channels already exists"). A shared database also
lets one test observe rows created by another.

Every other in-memory test database in this repo names itself from
t.Name() instead (tenant_api_key_test.go, memory/service_test.go,
and others); this helper was the only one still using the wall clock.
Switch to the same convention: t.Name() is unique per test function,
which is all that's needed here since none of the lifecycle tests
call the helper from subtests.

Added TestNewLifecycleTestDBIsolatesConcurrentTests, which runs the
seed and the isolation check as actual parallel subtests rather than
sequentially, closer to the real collision scenario than a plain
sequential pair. Confirmed it fails with the old DSN scheme (fixed
name, forcing the collision) and passes with the fix; ran the full
package 8 times as separate `go test` invocations, matching how the
race is actually triggered, with -race and no failures.

Fixes #3198

Signed-off-by: Ankit Jha <jhaankit373@gmail.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* test(im): close the lifecycle test database and keep its name unique

Review on #3415: switching the DSN to t.Name() fixed the collision between
tests started in the same tick but broke repeated runs. t.Name() is stable
across -count iterations in one process, and newLifecycleTestDB never closed
the sql.DB, so a shared-cache in-memory database outlived the iteration that
created it and the next CREATE TABLE failed with "table im_channels already
exists".

Reproduced with the reported command:

    go test ./internal/im -run '^TestNewLifecycleTestDBIsolatesConcurrentTests$' -count=2

Two changes, both needed:

- t.Cleanup closes the sql.DB immediately after opening, so the database is
  released with the test. Registered before the caller's own cleanups, which
  therefore still run first and can use the database while stopping a service.
- A process-wide sequence number in the name, so a single test calling the
  helper twice gets two databases; those overlap before any cleanup runs, so
  closing alone is not sufficient.

Added the repeated-run check that was asked for, plus one asserting the
connection is actually closed. Verified each half is load-bearing: dropping the
cleanup fails TestNewLifecycleTestDBClosesItsConnection, dropping the sequence
fails TestNewLifecycleTestDBIsUsableTwiceInOneProcess. Package is green at
-count=1 and -count=3 under -race.

---------

Signed-off-by: Ankit Jha <jhaankit373@gmail.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-20 11:24:28 +08:00
..
dingtalk fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
feishu fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
mattermost fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
qqbot fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
slack fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
telegram fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
wechat refactor: remove unused private Go helpers 2026-09-17 15:51:51 +08:00
wecom fix(im): handle WeCom 32-byte PKCS7 padding (#2848) 2026-08-28 15:40:42 +08:00
yunzhijia fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
adapter.go fix(im/feishu): show progress card in full output mode (#2909) 2026-09-01 13:09:11 +08:00
callback_validation_test.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
channel_agent_name_test.go fix(i18n): 修复内置智能体名称与描述不随界面语言切换的问题 (#2828) 2026-08-27 11:53:45 +08:00
channel_kb_scope_test.go fix(security): close the low-severity shared-space findings (#3416) 2026-09-18 22:58:46 +08:00
channel_mapping_test.go feat(im,datasource): support Lark, Feishu's international edition 2026-07-17 11:05:54 +08:00
channel_security.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
channel_security_test.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
cmd_clear.go feat(im): add slash-command system with /help, /info, /search, /stop, /clear 2026-03-20 15:49:59 +08:00
cmd_help.go feat(im): add slash-command system with /help, /info, /search, /stop, /clear 2026-03-20 15:49:59 +08:00
cmd_info.go feat(im): add slash-command system with /help, /info, /search, /stop, /clear 2026-03-20 15:49:59 +08:00
cmd_search.go fix(search): apply tag filters to knowledge search 2026-07-06 23:30:33 +08:00
cmd_stop.go feat(im): add slash-command system with /help, /info, /search, /stop, /clear 2026-03-20 15:49:59 +08:00
command.go feat(im): add slash-command system with /help, /info, /search, /stop, /clear 2026-03-20 15:49:59 +08:00
command_registry.go feat(im): add slash-command system with /help, /info, /search, /stop, /clear 2026-03-20 15:49:59 +08:00
content_rewrite_test.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
credentials.go refactor(im): move adapter factories into per-platform subpackages 2026-04-29 20:08:22 +08:00
file_message_test.go fix(im): tighten DingTalk rich-text follow-up handling 2026-08-24 14:51:04 +08:00
full_output_test.go fix(feishu): preserve active streams during long-running QA 2026-09-14 22:19:53 +08:00
identity_test.go test: address PR review follow-ups for OAuth and logger cleanup 2026-07-01 17:31:42 +08:00
im_config_warning_test.go fix(im): render resource:// images in IM channels (nginx /r/ + config guards) 2026-07-28 21:25:12 +08:00
im_file_service_test.go refactor(storage): extract storage reference URL rewriting into internal/storageurl 2026-08-05 14:42:51 +08:00
mode.go refactor(im): move adapter factories into per-platform subpackages 2026-04-29 20:08:22 +08:00
oauth_notice_test.go feat(im): include per-service MCP OAuth URLs in IM auth notices 2026-07-01 17:53:54 +08:00
qa_exit_test.go fix(im): finalize replies after agent QA returns (#3261) 2026-09-15 17:37:40 +08:00
qaqueue.go feat: add unit tests for COS object name parsing and enhance error handling 2026-05-29 13:47:32 +08:00
service.go fix(security): close the low-severity shared-space findings (#3416) 2026-09-18 22:58:46 +08:00
service_agent_test.go fix(integrations): polish agent filter UX and embed session rebind 2026-06-24 20:09:19 +08:00
service_lifecycle_test.go test(im): close the lifecycle test database and keep its name unique (#3433) 2026-09-20 11:24:28 +08:00
service_quote_test.go fix(im): anti-hallucination for non-text quotes and unprocessable media messages 2026-04-03 11:34:22 +08:00
session_not_found_test.go fix(im): recover from deleted session when GetSession returns app sentinel (#1499) 2026-05-27 11:51:11 +08:00
session_test.go fix(im): tighten DingTalk rich-text follow-up handling 2026-08-24 14:51:04 +08:00
session_title_test.go feat(im): IM session improvements — titles, in-flight recovery, classification 2026-06-12 17:01:28 +08:00
stream_delivery_test.go fix(feishu): preserve active streams during long-running QA 2026-09-14 22:19:53 +08:00
stream_display_test.go feat(memory): add cross-session long-term memory 2026-08-13 18:00:02 +08:00
stream_exit_test.go fix(im): preserve errors emitted after agent completion 2026-09-15 17:56:54 +08:00
stream_lifecycle_test.go fix(im): address stream display review feedback 2026-06-24 10:33:55 +08:00
stream_section.go fix(im): address stream display review feedback 2026-06-24 10:33:55 +08:00
stream_test.go feat(memory): add cross-session long-term memory 2026-08-13 18:00:02 +08:00
supervisor.go fix(im): prevent DingTalk stream connection from going stale 2026-06-22 15:04:23 +08:00
think.go feat(im,datasource): support Lark, Feishu's international edition 2026-07-17 11:05:54 +08:00
think_test.go feat(memory): add cross-session long-term memory 2026-08-13 18:00:02 +08:00
tool_display.go refactor(agent): consolidate knowledge retrieval tools into search_knowledge, read_document, list_documents (#3381) 2026-09-18 14:12:22 +08:00
tool_display_test.go feat(agent): stream live +/- progress for sandbox write and edit 2026-09-02 23:36:58 +08:00
types.go feat(im): add Yunzhijia integration 2026-07-21 12:24:33 +08:00
types_summary_test.go fix(security): redact IM list credentials and harden MinerU SSRF 2026-07-02 17:58:20 +08:00
types_test.go feat(im): add Yunzhijia integration 2026-07-21 12:24:33 +08:00