WeKnora/internal/router
tayadwx a1450d382e
fix(knowledge): claim cloned and released document images in the resource catalog (#3752)
* fix(knowledge): claim cloned and released document images in the catalog

#3493 binds images at parse time (bindStoredImages), which covers ingestion
but not the two paths that move image ownership:

Clone. A copied image is written as a new object, yet nothing claimed it for
the destination knowledge, so the KB file proxy answered 403 and cloned
documents rendered without images. The copy now goes through SaveBytes into
the servable exports/ namespace (CopyFile wrote to the knowledge-scoped
upload layout the proxy rejects), is claimed by the destination knowledge,
and CloneChunk / FAQ clone bind the handles left in chunk content and
image_info.

Delete. Release only looked at multimodal ImageInfo, which stays empty for
documents whose images live in markdown alone, so those objects outlived the
knowledge that owned them. The release set is now the union of ImageInfo URLs
and the bindings recorded for the knowledge being removed, with source_file
excluded so reparse and cleanup keep the original document.

The parse-path claim from the earlier attempt is dropped: ProcessDocument
already gets it from bindStoredImages, and the removed test only string
matched that call in the source. Every claim path stays best-effort,
including the clone path, which used to fail the whole clone and delete the
fresh copy when a single Bind errored.

* fix(knowledge): keep markdown-only images out of the pre-reindex cleanup

cleanupKnowledgeResources runs before a knowledge is re-indexed -- a manual
update, a reparse, a move with reparse -- not before it is removed. Unioning
in the catalog bindings there released a solely owned markdown-only
attachment, deleteExtractedImages deleted the file, and the catalog file
service marked the resource deleted. The re-claim that runs after the cleanup
resolves through a state=active lookup, so it could never bind that handle
again: the republished body was left pointing at a deleted image.

Cleanup collects ImageInfo URLs alone again. The paths that do remove a
knowledge entry (executeKnowledgeDelete, ProcessKBDelete) keep the union, which
is what lets markdown-only images be released when the knowledge actually goes
away.

Reported by @lyingbug in review on #3752.

---------

Co-authored-by: tayadwx <tayadwx@users.noreply.github.com>
2026-10-09 13:01:26 +08:00
..
deployment_capabilities.go feat(lite): install and run skills on the host (#3661) 2026-09-24 21:30:34 +08:00
deployment_capabilities_test.go feat(sandbox): run unpinned Lite sessions on the host OS sandbox (#3549) 2026-09-22 19:35:03 +08:00
embed_frame_policy_test.go fix(embed): enforce host origin allowlists on framed pages 2026-09-14 18:03:57 +08:00
files.go fix(security): close cross-workspace access paths in shared spaces (#3408) 2026-09-18 22:00:02 +08:00
model_catalog_test.go feat(models): add system admin model catalog console (#3662) 2026-09-24 16:31:45 +08:00
rbac.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
rbac_selfcheck_test.go Refine scoped API key capabilities 2026-07-07 12:00:13 +08:00
router.go revert: take the plugin system back out of main 2026-09-26 14:58:18 +08:00
router_api_key_capabilities_test.go fix(frontend): 修复复制模型时模型名称被改写的问题 (#3830) 2026-09-29 19:32:08 +08:00
router_api_key_management_test.go feat: support updating API key configuration 2026-08-12 11:43:03 +08:00
router_files_test.go fix(knowledge): claim cloned and released document images in the resource catalog (#3752) 2026-10-09 13:01:26 +08:00
router_knowledge_download_test.go feat(knowledge): add batch file downloads (#3300) 2026-09-16 15:40:10 +08:00
router_presigned_preview_test.go fix(security): close cross-workspace access paths in shared spaces (#3408) 2026-09-18 22:00:02 +08:00
router_presigned_test.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
router_static_test.go feat(resource): add stable resource registry with LLM-context alias compaction 2026-07-15 17:02:43 +08:00
router_wiki_test.go Remove redundant Wiki operation log 2026-07-28 11:18:33 +08:00
routes_agent.go revert: take the plugin system back out of main 2026-09-26 14:58:18 +08:00
routes_auth_tenant.go feat(models): add system admin model catalog console (#3662) 2026-09-24 16:31:45 +08:00
routes_chat.go feat(session): in-place rewind with workspace checkpoint reset (#3469) 2026-09-20 21:01:00 +08:00
routes_infra.go fix(frontend): 修复复制模型时模型名称被改写的问题 (#3830) 2026-09-29 19:32:08 +08:00
routes_knowledge.go feat(wiki): 增加跨知识库 Wiki 搜索 POST /wiki-search (#3535) 2026-09-25 22:22:58 +08:00
routes_mcp_endpoint.go feat(mcp): add built-in MCP server with per-workspace endpoints (#3371) 2026-09-17 22:40:05 +08:00
routes_mcp_endpoint_test.go fix(mcp): return accessible image URLs from existing tools (#3650) 2026-09-24 11:56:25 +08:00
routes_memory.go feat(memory): add cross-session long-term memory 2026-08-13 18:00:02 +08:00
static.go fix(embed): enforce host origin allowlists on framed pages 2026-09-14 18:03:57 +08:00
sync_task.go revert: take the plugin system back out of main 2026-09-26 14:58:18 +08:00
sync_task_options_test.go fix(knowledge): stop parses from getting stuck in processing or finalizing (#3696) 2026-09-25 13:26:38 +08:00
sync_task_retry_test.go fix: retry document summaries before fallback 2026-08-05 19:29:32 +08:00
task.go revert: take the plugin system back out of main 2026-09-26 14:58:18 +08:00
task_dead_letter_attempt_test.go fix(knowledge): stop parses from getting stuck in processing or finalizing (#3696) 2026-09-25 13:26:38 +08:00
task_delete_scope_test.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
task_inspector.go feat(knowledge): flag documents that stop making progress (#3557) 2026-09-22 21:34:08 +08:00
task_inspector_errors.go fix(task-inspector): handle lazy queue not found errors 2026-07-23 14:24:21 +08:00
task_inspector_errors_test.go fix(knowledge): recover stranded deleting rows and align the KB count (#3367) 2026-09-18 00:55:44 +08:00
task_inspector_kb_cancel_test.go fix(tasks): dequeue work for deleted knowledge bases 2026-07-23 12:17:14 +08:00
task_inspector_queued_ids_test.go feat(knowledge): flag documents that stop making progress (#3557) 2026-09-22 21:34:08 +08:00
task_inspector_runtime_test.go fix(task-inspector): handle lazy queue not found errors 2026-07-23 14:24:21 +08:00
task_processing_scope_test.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00