WeKnora/internal/handler
lyingbug 68e6c03dc4
fix(skills): upgrade outdated sandbox skills without rolling back the catalog or taking them offline (#3406)
* fix(skills): keep retries and catalog installs from rewriting the skill definition

Every install path wrote its archive back to the workspace catalog. After a
skill was re-registered as v2, sandboxes still on v1 are pinned to v1's
archive, so retrying one of them (a failed retry, or a ready skill retried
with guidance) reinstalled v1 and also moved the catalog definition back to
v1 and deleted v2's archive.

Installs now carry where their archive came from. Only an upload or a source
pull is a new definition; a retry or a catalog install uses bytes the
workspace already stores and never rewrites the definition. A retry of a
pinned install keeps its pin and replays its own version, and bytes that
neither the definition nor the row holds are refused with a conflict.

The catalog listing also reports each installation's version so the UI can
show what an upgrade moves from and to.

* feat(frontend): upgrade outdated skill installs from the catalog, sandbox drawer and agent editor

An install whose archive differs from the catalog was flagged as outdated,
but nothing could move it to the catalog version: the install drawer hid
ready installs, and the manage drawer only offered a retry, which replays
the sandbox's own archive.

- Skill settings: cards with outdated installs show an upgrade button that
  opens the install drawer with every outdated sandbox preselected. The
  add wizard and install drawer also let outdated ready installs be picked,
  labelled with the version they move from and to.
- Sandbox skill drawer: an outdated skill shows a "new version" row whose
  upgrade button installs the catalog onto that one sandbox.
- Agent editor: skills on the chosen sandbox that are outdated show the
  version change and an upgrade button, both for admins only, matching the
  admin-only catalog install. The install progress entry, which opens a
  drawer backed by admin-only endpoints, is now admin-only too.
- A skill that is being upgraded is no longer pruned from the agent's
  selected skills while it is briefly not ready.

The outdated check is shared in utils/skillUpgrade.ts.

* feat(skills): keep the previous version serving while an upgrade runs or after it fails

An install rewrote the row to the new version and marked it installing as
soon as it started, and the agent is only offered ready rows. So an upgrade
took the skill away from every sandbox for its whole run, and a failed
upgrade kept it away, even though the image pointer only moves on success
and the previous version was in the image the whole time.

The row now records what it described when it was last ready (served:
version, description, instructions, digest, the archive its files come from,
and the snapshot that installed it). The agent's usable set, member env
acceptance and the @-mention list read TenantSkillEntity.ServedView, which
is that version marked ready while the row is installing or failed. A
successful install clears it and releases its archive; a failure or a stop
keeps it.

Keeping that consistent:
- The served archive counts as a reader when a bundle is released or
  replaced by a re-registered catalog, so v1's files stay readable while v2
  installs.
- The reaper and a failed removal put the served version back when the image
  never moved past it, instead of labelling v1's files with the upgrade's
  metadata. A stuck upgrade whose chain cannot be read is left alone, since
  v1 keeps serving meanwhile.
- The env declaration is stored after the pointer moves rather than before
  the snapshot, so an upgrade that fails late cannot drop the admin value of
  a variable the previous version still reads.

Migration 000104 adds tenant_skills.served. The console says "upgrading,
still running 1.1.0" or "upgrade failed, still running 1.1.0", the agent
editor keeps such skills selectable, and the upgrade texts no longer warn
that the skill goes offline.

* fix(skills): offer only the upgrade to installs the catalog has moved past

Review follow-up on the upgrade flow.

- An install that differs from the catalog, ready or failed, is now offered
  the upgrade and not the retries. The retry icon and the retry-with-guidance
  box both replay the archive the install is pinned to, so next to an
  Upgrade button they reinstalled the version the operator came to leave
  behind. A failed first install of v1 whose catalog has since moved to v2
  used to retry v1 from the drawer while the agent editor's Install went to
  v2; every entry now goes to v2, and the agent editor labels it "Upgrade".
  The drawer explains that the failed install is replaced by the catalog
  version.
- A catalog install or a retry reuses the definition that already holds its
  bytes instead of re-running the catalog upsert, which rewrote the row and
  bumped its updated_at every time the skill was installed somewhere. The
  upsert still runs for a definition that does not exist yet or whose object
  was lost.
2026-09-18 20:27:43 +08:00
..
dto feat(mcp)!: persist tool catalogs and add guided configuration (#3118) 2026-09-09 13:34:56 +08:00
session fix(agent): search bound knowledge bases before answering, and pass suggested-question origins (#3400) 2026-09-18 17:00:47 +08:00
audit_log.go Remove redundant Wiki operation log 2026-07-28 11:18:33 +08:00
audit_log_test.go feat(knowledge): add scoped activity audit trail 2026-07-23 10:50:32 +08:00
auth.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
auth_browser_preferences_test.go feat(browser): polish connection settings, open tasks in a new window, and streamline prompts (#3193) 2026-09-11 21:28:58 +08:00
auth_change_password_test.go feat: support complex password (#2929) 2026-09-01 11:50:10 +08:00
auth_desktop_security_test.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
auth_oidc_start_test.go feat(auth): add /auth/oidc/start endpoint for direct 302 OIDC login 2026-08-11 15:41:48 +08:00
auth_register_by_invite.go feat: support complex password (#2929) 2026-09-01 11:50:10 +08:00
auth_register_by_invite_tenant_test.go feat: support complex password (#2929) 2026-09-01 11:50:10 +08:00
auth_register_invite_only_test.go feat: support complex password (#2929) 2026-09-01 11:50:10 +08:00
chunk.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
chunker_debug.go fix(chunking): normalize line endings before splitting / 在分块前统一换行符 2026-08-05 19:24:45 +08:00
chunker_debug_test.go fix(chunking): normalize line endings before splitting / 在分块前统一换行符 2026-08-05 19:24:45 +08:00
custom_agent.go fix(agent): PUT no longer erases the avatar, and driver errors stay server-side (#3230) 2026-09-14 20:50:15 +08:00
custom_agent_api_key_scope_test.go feat(agent): enhance suggested questions API with tag scopes 2026-07-17 10:19:43 +08:00
custom_agent_avatar_test.go fix(agent): PUT no longer erases the avatar, and driver errors stay server-side (#3230) 2026-09-14 20:50:15 +08:00
custom_agent_sandbox_test.go feat(sandbox) (#2301) 2026-08-10 21:28:20 +08:00
datasource.go refactor(terminology): rename user-facing tenant labels to workspace 2026-07-14 16:14:43 +08:00
datasource_credentials.go refactor(terminology): rename user-facing tenant labels to workspace 2026-07-14 16:14:43 +08:00
datasource_test.go Validate sync log limit parameter 2026-06-12 22:52:25 +08:00
deployment_capabilities.go feat(mcp): add built-in MCP server with per-workspace endpoints (#3371) 2026-09-17 22:40:05 +08:00
deployment_capabilities_test.go feat: require opt-in for the Docker sandbox backend (#2936) 2026-09-01 15:42:28 +08:00
document_write_scope_test.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
embed_allowed_origins_test.go fix(embed): enforce host origin allowlists on framed pages 2026-09-14 18:03:57 +08:00
embed_channel.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
embed_channel_exchange_test.go refactor(context): replace middleware.EmbedChannelContextKey with types.EmbedChannelContextKey 2026-08-13 18:00:02 +08:00
embed_flow_test.go refactor: remove Neo4j-based conversation memory feature 2026-07-18 23:41:48 +08:00
embed_resource_urls_test.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
embed_session_test.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
evaluation.go feat: 新增API Key认证支持,优化Swagger文档安全配置 2025-12-22 15:01:09 +08:00
faq.go feat(faq): filter entries by enabled status (#3157) 2026-09-10 14:42:59 +08:00
faq_enabled_filter_test.go feat(faq): filter entries by enabled status (#3157) 2026-09-10 14:42:59 +08:00
im.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
im_platform_test.go feat(im,datasource): support Lark, Feishu's international edition 2026-07-17 11:05:54 +08:00
initialization.go fix(initialization): stamp the KB's tenant onto created models 2026-09-17 13:09:34 +08:00
initialization_config_redaction_test.go fix(security): close init config and parser-check redaction gaps 2026-07-02 14:41:42 +08:00
initialization_fill_secrets_test.go fix(initialization): pass stored ExtraConfig to model connection test 2026-09-07 11:43:44 +08:00
initialization_model_tenant_test.go fix(initialization): stamp the KB's tenant onto created models 2026-09-17 13:09:34 +08:00
kb_access.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
kb_access_test.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
knowledge.go refactor: remove unused private Go helpers 2026-09-17 15:51:51 +08:00
knowledge_api_key_scope_test.go fix(api-keys): close KB scope gaps in handlers and CloneContext 2026-07-07 12:00:13 +08:00
knowledge_download.go feat(knowledge): add batch file downloads (#3300) 2026-09-16 15:40:10 +08:00
knowledge_download_test.go feat(knowledge): add batch file downloads (#3300) 2026-09-16 15:40:10 +08:00
knowledge_folder_test.go feat(knowledge): store folder path for folder uploads and expose folder tree API 2026-08-04 20:45:29 +08:00
knowledge_move_gate_test.go fix: reject cross-store reuse_vectors knowledge move 2026-06-05 15:00:41 +08:00
knowledge_mutation_admission_test.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
knowledge_ownership_test.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
knowledge_preview_security_test.go fix(security): harden outbound requests and file previews 2026-07-02 19:15:46 +08:00
knowledge_spans_test.go fix(knowledge): recover tasks safely after server restart 2026-07-14 17:55:26 +08:00
knowledge_tag_ids_test.go fix(knowledge): harden multi-tag data integrity and UX follow-ups 2026-06-26 10:52:52 +08:00
knowledge_transfer_test.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
knowledgebase.go feat(knowledge): derive knowledge base descriptions from document profiles (#3370) 2026-09-17 22:21:55 +08:00
knowledgebase_copy_preflight_test.go Simplify KB duplicate API and improve naming/docs coverage. 2026-07-08 20:55:54 +08:00
knowledgebase_hybrid_search_resource_urls_test.go feat(api): honor resource_urls=public on hybrid-search 2026-08-26 17:40:54 +08:00
knowledgebase_hybrid_search_test.go feat(api): honor resource_urls=public on hybrid-search 2026-08-26 17:40:54 +08:00
knowledgebase_not_found_test.go feat(memory): add cross-session long-term memory 2026-08-13 18:00:02 +08:00
knowledgebase_pr3_response_test.go feat(knowledge-base): validate vector store bindings on create, copy, and delete 2026-05-18 15:58:46 +08:00
knowledgebase_pr5_list_test.go feat: expose KB ↔ vector store binding in list, editor, and detail UI 2026-05-22 17:40:10 +08:00
knowledgebase_request_test.go feat(knowledge-base): validate vector store bindings on create, copy, and delete 2026-05-18 15:58:46 +08:00
list_pagination.go fix(handler): validate knowledge search pagination 2026-08-24 14:16:35 +08:00
list_pagination_test.go fix(handler): validate knowledge search pagination 2026-08-24 14:16:35 +08:00
mcp_credentials.go refactor(terminology): rename user-facing tenant labels to workspace 2026-07-14 16:14:43 +08:00
mcp_endpoint.go feat(mcp): add built-in MCP server with per-workspace endpoints (#3371) 2026-09-17 22:40:05 +08:00
mcp_metadata.go feat(mcp)!: persist tool catalogs and add guided configuration (#3118) 2026-09-09 13:34:56 +08:00
mcp_metadata_test.go feat(mcp)!: persist tool catalogs and add guided configuration (#3118) 2026-09-09 13:34:56 +08:00
mcp_oauth.go fix(mcp): coordinate OAuth token refresh and authorization polling 2026-07-23 15:35:24 +08:00
mcp_service.go feat(mcp)!: streamline setup and use short routing handles 2026-09-09 16:11:52 +08:00
mcp_tool_approval_test.go feat(mcp): add per-tool enable toggle (#2989) 2026-09-05 17:19:20 +08:00
mcp_usage_instructions.go feat(mcp)!: streamline setup and use short routing handles 2026-09-09 16:11:52 +08:00
mcp_usage_instructions_test.go feat(mcp)!: streamline setup and use short routing handles 2026-09-09 16:11:52 +08:00
me_env_var.go feat(sandbox): inject per-user and workspace skill env vars at execution 2026-08-27 14:32:00 +08:00
me_env_var_test.go feat(sandbox): inject per-user and workspace skill env vars at execution 2026-08-27 14:32:00 +08:00
memory.go fix(memory): preserve extraction progress and atomic memory updates (#3224) 2026-09-13 00:04:16 +08:00
memory_consistency_test.go fix(memory): preserve extraction progress and atomic memory updates (#3224) 2026-09-13 00:04:16 +08:00
message.go fix(api): address resource_urls review follow-ups 2026-08-05 14:42:51 +08:00
message_resource_urls_test.go fix(api): close the resource_urls=public gaps found in review 2026-08-05 14:42:51 +08:00
message_session_not_found_test.go fix(chat): stabilize history pagination and keep message order 2026-05-20 21:03:39 +08:00
message_suggestion.go fix(sessions): 放行 embed 运行时读取自身会话,修复追问建议 500 与刷新丢对话 2026-07-30 17:51:34 +08:00
message_suggestion_test.go fix(sessions): 放行 embed 运行时读取自身会话,修复追问建议 500 与刷新丢对话 2026-07-30 17:51:34 +08:00
model.go fix(models): show usage details when deletion is blocked (#2975) 2026-09-02 17:20:37 +08:00
model_credentials.go refactor(terminology): rename user-facing tenant labels to workspace 2026-07-14 16:14:43 +08:00
model_test.go feat(models): add model test debugger for saved model configs 2026-06-25 17:05:33 +08:00
organization.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
organization_discovery_security_test.go fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
rbac_lookups.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
rbac_lookups_test.go refactor(terminology): rename user-facing tenant labels to workspace 2026-07-14 16:14:43 +08:00
sandbox_check.go feat(sandbox): add tenant-configurable network policy (#2995) 2026-09-03 10:49:46 +08:00
sandbox_check_test.go feat(sandbox): add tenant-configurable network policy (#2995) 2026-09-03 10:49:46 +08:00
sandbox_config.go feat(sandbox): add a graphical desktop to session sandboxes (#3245) 2026-09-14 20:37:37 +08:00
sandbox_config_test.go feat(sandbox): pin Cube DNS on templates and freeze skill snapshot configs 2026-08-26 16:56:26 +08:00
sandbox_skill.go fix(skills): upgrade outdated sandbox skills without rolling back the catalog or taking them offline (#3406) 2026-09-18 20:27:43 +08:00
sandbox_skill_env_test.go feat(sandbox): inject per-user and workspace skill env vars at execution 2026-08-27 14:32:00 +08:00
sandbox_skill_test.go fix(skills): verify runtime prerequisites and support installer steering 2026-09-09 23:04:59 +08:00
shared_agent_access.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
shared_agent_access_test.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
skill_catalog.go refactor(skills): enhance skill upload size management and error handling 2026-09-02 15:08:05 +08:00
skill_catalog_test.go refactor(skills): enhance skill upload size management and error handling 2026-09-02 15:08:05 +08:00
skill_handler.go fix(skills): keep catalog bundles consistent and surface partial installs 2026-08-28 15:17:37 +08:00
skill_handler_test.go feat(agent): unify sandbox tools and drop host preloaded skills (#3033) 2026-09-05 16:45:59 +08:00
storage_allowlist.go fix(storage): align default provider fallback with STORAGE_ALLOW_LIST 2026-07-15 11:05:00 +08:00
storagebackend.go feat(storage): add storage backend management API and UI enhancements 2026-07-15 14:54:39 +08:00
system.go refactor(system): drop idempotent flag from create-user response body 2026-09-07 17:30:47 +08:00
system_admin_audit_test.go test(system): cover system.* audit constants + emitAdminAudit contract 2026-05-26 21:13:56 +08:00
system_parser_check_test.go fix(security): close init config and parser-check redaction gaps 2026-07-02 14:41:42 +08:00
system_password_reset_test.go feat(system): add admin password reset with session revocation 2026-07-13 20:11:00 +08:00
system_runtime_test.go fix(knowledge): recover stranded deleting rows and align the KB count (#3367) 2026-09-18 00:55:44 +08:00
system_storage_engine_test.go feat(storage): improve storage connectivity error handling and multi-instance support 2026-07-15 14:54:39 +08:00
system_storage_ssrf_test.go fix(security): close remaining GHSA gaps from security triage 2026-07-02 15:03:53 +08:00
system_user_create_test.go refactor(system): drop idempotent flag from create-user response body 2026-09-07 17:30:47 +08:00
tag.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
tag_delete_test.go refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
task_progress_auth.go fix(security): enforce KB access on wiki reads and related IDOR paths 2026-07-02 12:06:22 +08:00
task_progress_auth_test.go fix(security): enforce KB access on wiki reads and related IDOR paths 2026-07-02 12:06:22 +08:00
tenant.go feat(knowledge): derive knowledge base descriptions from document profiles (#3370) 2026-09-17 22:21:55 +08:00
tenant_api_key_validation_test.go feat: support updating API key configuration 2026-08-12 11:43:03 +08:00
tenant_invitation.go fix(invitation): harden auto-accept follow-ups from code review 2026-08-10 15:47:29 +08:00
tenant_invitation_accept_by_token_test.go feat: 邀请链接在 invite_only 模式下改为登录后加入空间 2026-08-10 14:57:38 +08:00
tenant_invitation_auto_accept_test.go fix(invitation): harden auto-accept follow-ups from code review 2026-08-10 15:47:29 +08:00
tenant_invite_link.go fix: prevent API keys from assigning owner role 2026-07-23 16:04:42 +08:00
tenant_member.go fix(invitation): harden auto-accept follow-ups from code review 2026-08-10 15:47:29 +08:00
tenant_member_test.go feat(memory): add cross-session long-term memory 2026-08-13 18:00:02 +08:00
tenant_parser_ssrf_test.go fix(security): redact IM list credentials and harden MinerU SSRF 2026-07-02 17:58:20 +08:00
tenant_policy.go feat(auth): support tenantless provisioning and gated self-service workspace creation 2026-07-13 18:13:51 +08:00
tenant_secret_disclosure_test.go refactor(api-keys): remove API key reset endpoint and update documentation 2026-07-07 12:00:13 +08:00
tenant_self_service_policy_test.go feat: support complex password (#2929) 2026-09-01 11:50:10 +08:00
upload_limit.go refactor(skills): improve skill bundle size handling and error management 2026-09-02 15:08:05 +08:00
upload_limit_test.go refactor(skills): improve skill bundle size handling and error management 2026-09-02 15:08:05 +08:00
user_resource_favorite.go refactor(terminology): rename user-facing tenant labels to workspace 2026-07-14 16:14:43 +08:00
vectorstore.go refactor(terminology): rename user-facing tenant labels to workspace 2026-07-14 16:14:43 +08:00
web_search.go docs(api): add and fix swag annotations on handlers 2026-05-12 13:16:58 +08:00
web_search_provider.go refactor(terminology): rename user-facing tenant labels to workspace 2026-07-14 16:14:43 +08:00
web_search_provider_credentials.go refactor(terminology): rename user-facing tenant labels to workspace 2026-07-14 16:14:43 +08:00
wechat_qrcode.go docs(api): add and fix swag annotations on handlers 2026-05-12 13:16:58 +08:00
weknoracloud.go refactor(terminology): rename user-facing tenant labels to workspace 2026-07-14 16:14:43 +08:00
wiki_page.go feat(memory): add cross-session long-term memory 2026-08-13 18:00:02 +08:00