WeKnora/internal
tayadwx 911a1490ea
fix(wiki): enrich cited chunk content with image captions in Reduce phase 实体/摘要页面引用子块时同样使用富文本内容 (#3292)
* fix(wiki): enrich cited chunk content with image captions in Reduce phase

The citation-pass comment claims image/ocr chunks are "already merged
into the text content via reconstructEnrichedContent", but that function
has exactly one call site — the per-document summary page. The Reduce /
page-edit phase resolves cited chunks straight from the repository and
feeds the LLM bare Markdown image links with no caption or OCR context.

This mismatch is observable: on concept/entity pages generated from an
image-heavy knowledge base, the page-editing model receives
![filename](wkimg:NNN) with no way to judge the image, and empirically
either copies the image links verbatim or drops them wholesale —
including real content images. A controlled experiment where the same
image reached two pages byte-identically produced opposite keep/drop
decisions, and <image_caption> appeared in 0 of 9 outgoing page-edit
requests.

resolveCitedChunks now collects image_info for the cited text chunks
(CollectImageInfoByChunkIDs, one query per knowledge batch, outside the
per-page loop) and inlines it with EnrichContentWithImageInfo — the same
enrichment the summary path uses. Image info collection skips disabled
child chunks, so downstream decorative-image cleanup composes with this
path automatically.

* test(wiki): cover cited-chunk image enrichment in resolveCitedChunks

Add unit tests asserting that cited text chunks reach the Reduce phase
enriched with caption/OCR info from their enabled image child chunks,
that disabled children are skipped (decorative-image cleanup composes),
and that unknown chunk IDs still fall through gracefully.

---------

Co-authored-by: tayadwx <tayadwx@users.noreply.github.com>
2026-09-21 13:13:48 +08:00
..
agent refactor(models): rebuild vendor integration on protocol + catalog + vendor layers (#3470) 2026-09-20 21:28:23 +08:00
application fix(wiki): enrich cited chunk content with image captions in Reduce phase 实体/摘要页面引用子块时同样使用富文本内容 (#3292) 2026-09-21 13:13:48 +08:00
assets feat(assets): add ASR test audio file and embed it in the application 2026-04-02 21:27:27 +08:00
browserskill fix(browser): rebase BrowserSkill patches and use native session lifecycle 2026-09-20 00:09:50 +08:00
common fix(markdown): sanitize invalid UTF-8 and NUL bytes 2026-08-31 12:24:35 +08:00
config feat(knowledge): derive knowledge base descriptions from document profiles (#3370) 2026-09-17 22:21:55 +08:00
container fix(agent): scope the @Skill and @MCP pickers to the agent that will run (#3475) 2026-09-21 13:02:34 +08:00
database feat(artifacts): let users delete generated files (#3447) 2026-09-20 13:01:46 +08:00
datasource fix(ima): traverse subfolders using list response media IDs 2026-09-19 22:42:57 +08:00
embedpolicy fix(embed): enforce host origin allowlists on framed pages 2026-09-14 18:03:57 +08:00
errors feat(agent): keep long sandbox turns from truncating, overflowing, or rewriting files 2026-09-02 22:09:09 +08:00
event fix(agent): end the turn when the completion cap truncates an answer (#3449) 2026-09-20 13:17:50 +08:00
filetransport refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
handler fix(agent): scope the @Skill and @MCP pickers to the agent that will run (#3475) 2026-09-21 13:02:34 +08:00
im test(im): close the lifecycle test database and keep its name unique (#3433) 2026-09-20 11:24:28 +08:00
infrastructure fix(chunking): 修复内联 HTML 表格与保护模式导致的超长 chunk (#3404) 2026-09-18 21:10:17 +08:00
ipclass fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
logger fix(sandbox): record product-level Langfuse spans and detach idle sweeps 2026-08-31 19:42:32 +08:00
mcp fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
mcpserver refactor(agent): consolidate knowledge retrieval tools into search_knowledge, read_document, list_documents (#3381) 2026-09-18 14:12:22 +08:00
middleware fix(security): close the low-severity shared-space findings (#3416) 2026-09-18 22:58:46 +08:00
modelcontext refactor(models): rebuild vendor integration on protocol + catalog + vendor layers (#3470) 2026-09-20 21:28:23 +08:00
models refactor(embedding): move the wire formats into protocol packages, and correct the vendor facts (#3500) 2026-09-21 11:55:38 +08:00
ratelimit feat(embed): add backend embed channels with auth and rate limiting (#1657) 2026-06-12 23:10:39 +08:00
router refactor(models): rebuild vendor integration on protocol + catalog + vendor layers (#3470) 2026-09-20 21:28:23 +08:00
runtime fix(redis): harden TLS tests and surface TLS config at startup 2026-07-06 23:04:52 +08:00
sandbox feat(session): in-place rewind with workspace checkpoint reset (#3469) 2026-09-20 21:01:00 +08:00
searchutil fix(chat): keep OCR/caption text of scanned-page image hits in merge (#3064) 2026-09-07 11:38:47 +08:00
storageallowlist fix(storage): align default provider fallback with STORAGE_ALLOW_LIST 2026-07-15 11:05:00 +08:00
storageurl refactor(resource-access): unify scoped authorization and transfer recovery (#3097) 2026-09-08 15:36:33 +08:00
stream feat(session): in-place rewind with workspace checkpoint reset (#3469) 2026-09-20 21:01:00 +08:00
textconv fix: remove GPL converter and bundle third-party license sources 2026-09-08 15:19:10 +08:00
tracing/langfuse fix(milvus): preserve keyword retrieval scores 2026-09-17 11:59:40 +08:00
types fix(queue): order ClaimBatch by fail_count so retries cannot starve new work (#3444) 2026-09-21 13:00:29 +08:00
utils refactor: remove unused private Go helpers 2026-09-17 15:51:51 +08:00