WeKnora/docreader/tests
林SO f307d3dc94
fix: remove temp file when TempFileContext write fails inside __enter__ (#3495)
* fix: remove temp file when TempFileContext write fails inside __enter__

TempFileContext.__enter__ creates a NamedTemporaryFile(delete=False) and then
calls write()/flush() with no error handling. If either raises (ENOSPC, quota,
any I/O error), the exception escapes __enter__, and Python's with-statement
never calls __exit__ for a context manager whose __enter__ failed. __exit__ is
the only place the file is closed and removed, so the file leaks permanently;
delete=False means GC will not remove it either.

doc_parser.py uses this to spill every uploaded .doc's full bytes to disk, so
one disk-pressure event leaves the whole document behind and makes the
pressure worse.

Wrap write/flush in try/except, close and remove the file, then re-raise.
Success path and the exception-inside-body path are unchanged.

Adds docreader/tests/test_tempfile_context.py covering the failure-injection
case (fails on the old code), the normal roundtrip, and body exceptions.

* fix: unlink temp file even if close() re-raises after ENOSPC

close() flushes again, so the ENOSPC path can skip os.remove and still leak.
Share one cleanup helper that always unlinks and preserves the original error.

---------

Co-authored-by: wizardchen <wizardchen@tencent.com>
2026-09-21 14:21:07 +08:00
..
fixtures fix(docreader): preserve vertically merged table cells (#2657) 2026-08-12 10:59:49 +08:00
test_config.py test(docreader): align pdf JPEG quality default assertion 2026-06-17 17:18:57 +08:00
test_docx_merge.py fix(docreader): preserve vertically merged table cells (#2657) 2026-08-12 10:59:49 +08:00
test_docx_tables.py fix(docreader): keep DOCX table content in parsed text (#2898) 2026-08-31 17:56:17 +08:00
test_epub_parser.py feat: add EPUB and MHTML document support 2026-06-16 11:25:27 +08:00
test_excel_parser.py fix(docreader): avoid chart serialization during xlsx preprocessing 2026-08-12 13:26:19 +08:00
test_html_parser.py fix(knowledge): support local HTML uploads 2026-07-29 20:11:17 +08:00
test_markdown_table_util.py fix: stop markdown table regex catastrophic backtracking (#2770) 2026-08-24 18:08:07 +08:00
test_mhtml_parser.py fix(docreader): handle Header object when stripping mhtml header (#2902) 2026-08-31 17:14:58 +08:00
test_opendataloader_parser.py fix(security): harden outbound URL SSRF protection (#2626) 2026-08-10 13:24:14 +08:00
test_parser_concurrency.py fix(docreader): throttle heavy parser concurrency 2026-05-07 17:36:09 +08:00
test_parser_routing.py fix(parser): default ppt/pptx to markitdown when no engine rules (#2882) 2026-08-31 14:58:15 +08:00
test_pdf_embedded_images.py fix(docreader): keep pdfium bitmap alive while copying SMask pixels 2026-08-24 14:41:54 +08:00
test_pdf_router.py feat(docreader): support forcing PDF scanned-page OCR parsing 2026-06-25 17:30:22 +08:00
test_ppt_convert.py ci: add app frontend and docreader checks 2026-07-30 14:13:15 +08:00
test_ssrf.py fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
test_ssrf_proxy.py fix: align client sessions and integration request handling (#3305) 2026-09-16 16:20:57 +08:00
test_tempfile_context.py fix: remove temp file when TempFileContext write fails inside __enter__ (#3495) 2026-09-21 14:21:07 +08:00
test_web_parser.py fix(docreader): fail URL scrape instead of indexing error text (#2883) 2026-08-31 14:12:11 +08:00
test_xmind_parser.py feat(docreader): add XMind outline parsing (#2713) 2026-08-20 19:49:48 +08:00