From d3a3cc888d7dcbe23644394c67e5a5e2d032f24e Mon Sep 17 00:00:00 2001 From: wizardchen Date: Tue, 1 Sep 2026 21:08:37 +0800 Subject: [PATCH] fix(frontend): move sandbox uninstall into the manage drawer header The leftover danger-zone button sat under a wall of copy and opened a modal. Put a compact popconfirm on the title row instead. --- .../components/SandboxSkillsPanel.test.mjs | 12 +- .../src/components/SandboxSkillsPanel.vue | 104 ++++++++++-------- .../settings/SettingDrawer.test.mjs | 14 +++ .../src/components/settings/SettingDrawer.vue | 34 +++++- frontend/src/i18n/locales/en-US.ts | 1 + frontend/src/i18n/locales/ko-KR.ts | 1 + frontend/src/i18n/locales/ru-RU.ts | 1 + frontend/src/i18n/locales/zh-CN.ts | 1 + 8 files changed, 116 insertions(+), 52 deletions(-) create mode 100644 frontend/src/components/settings/SettingDrawer.test.mjs diff --git a/frontend/src/components/SandboxSkillsPanel.test.mjs b/frontend/src/components/SandboxSkillsPanel.test.mjs index c42857a3..5aee9b10 100644 --- a/frontend/src/components/SandboxSkillsPanel.test.mjs +++ b/frontend/src/components/SandboxSkillsPanel.test.mjs @@ -13,11 +13,17 @@ test('focused skill management expands env vars and transcript without a mid-pag assert.match(manageBlock, /onEnvFieldBlur/) assert.match(source, /isBusy\(skill\) \|\| !hasEnvEdits\(skill\)/) assert.match(manageBlock, /SkillInstallTimeline/) + assert.match(manageBlock, /Teleport/) assert.match(manageBlock, /settings\.skills\.manageUninstall/) - assert.match(manageBlock, /skill-manage__section--danger/) - assert.match(manageBlock, /managedSkill\.status !== 'installing'/) + assert.match(manageBlock, /manageUninstallConfirm/) + assert.match(manageBlock, /showHeaderUninstall/) + assert.match(source, /SETTING_DRAWER_HEADER_ACTIONS_ID/) + assert.match(source, /skill\.status === 'installing'/) assert.match(manageBlock, /skill-manage__section--remove/) - assert.match(manageBlock, /askRemove/) + assert.match(manageBlock, /t-popconfirm/) + assert.doesNotMatch(manageBlock, /askRemove/) + assert.doesNotMatch(manageBlock, /skill-manage__section--danger/) + assert.doesNotMatch(source, /useConfirmDelete/) assert.match(manageBlock, /skillRemoveDone/) assert.match(manageBlock, /progressStageText/) assert.match(source, /overlayUninstallStatus/) diff --git a/frontend/src/components/SandboxSkillsPanel.vue b/frontend/src/components/SandboxSkillsPanel.vue index 926d9ee3..b233c0f6 100644 --- a/frontend/src/components/SandboxSkillsPanel.vue +++ b/frontend/src/components/SandboxSkillsPanel.vue @@ -76,6 +76,28 @@
+ + + + {{ $t('settings.skills.manageUninstall') }} + + +

{{ $t('settings.sandbox.skillRemoveDone', { name: uninstallingName }) }}

@@ -124,6 +146,9 @@
  • {{ line }}
+
    +
  • {{ line }}
  • +

{{ $t('settings.sandbox.skillEnv.toggle') }}

{{ $t('settings.sandbox.skillEnv.workspaceHint') }}

@@ -211,25 +236,6 @@ :live="managedSkill.status === 'installing'" />
-
-

{{ $t('settings.skills.manageUninstall') }}

-

{{ deleteHint }}

-
    -
  • {{ line }}
  • -
- - {{ $t('settings.skills.manageUninstall') }} - -
@@ -502,16 +508,25 @@ - + +
{{ skill.version }}
@@ -548,14 +563,14 @@ +