From 2d37f8fd7d18c7a5871a9aa852c41bcb8eddcf2d Mon Sep 17 00:00:00 2001 From: wizardchen Date: Mon, 21 Sep 2026 14:28:08 +0800 Subject: [PATCH] fix(container): wire shared agent lookup for MCP handler --- internal/container/container.go | 12 +++++++++- internal/container/router_wiring_test.go | 28 ++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 internal/container/router_wiring_test.go diff --git a/internal/container/container.go b/internal/container/container.go index 04fc0b6b..5493ee04 100644 --- a/internal/container/container.go +++ b/internal/container/container.go @@ -537,7 +537,17 @@ func BuildContainer(container *dig.Container) *dig.Container { must(container.Provide(handler.NewInitializationHandler)) must(container.Provide(handler.NewAuthHandler)) must(container.Provide(handler.NewSystemHandler)) - must(container.Provide(handler.NewMCPServiceHandler)) + // Dig resolves exact types; adapt the registered service to the handler's + // narrower SharedAgentLookup interface at the composition boundary. + must(container.Provide(func( + mcpService interfaces.MCPServiceService, + toolApprovals interfaces.MCPToolApprovalService, + gate *approval.Gate, + models interfaces.ModelService, + agents interfaces.AgentShareService, + ) *handler.MCPServiceHandler { + return handler.NewMCPServiceHandler(mcpService, toolApprovals, gate, models, agents) + })) must(container.Provide(handler.NewMCPCredentialsHandler)) must(container.Provide(handler.NewMCPOAuthHandler)) must(container.Provide(handler.NewModelCredentialsHandler)) diff --git a/internal/container/router_wiring_test.go b/internal/container/router_wiring_test.go new file mode 100644 index 00000000..db444982 --- /dev/null +++ b/internal/container/router_wiring_test.go @@ -0,0 +1,28 @@ +package container + +import ( + "testing" + + "github.com/gin-gonic/gin" + "go.uber.org/dig" +) + +// Resolve the production dependency graph without opening connections or +// starting background workers. Handler tests alone do not catch missing DI types. +func TestRouterWiring(t *testing.T) { + for _, mode := range []struct { + name string + redisAddr string + }{ + {name: "lite"}, + {name: "redis", redisAddr: "localhost:6379"}, + } { + t.Run(mode.name, func(t *testing.T) { + t.Setenv("REDIS_ADDR", mode.redisAddr) + c := BuildContainer(dig.New(dig.DryRun(true))) + if err := c.Invoke(func(*gin.Engine) {}); err != nil { + t.Fatalf("resolve router dependencies: %v", err) + } + }) + } +}